Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> The sentinel function attribute is not understood by versions of
>> the gcc compiler prior to v4.0. At present, for earlier versions
>> of gcc, the build issues 108 warnings related to the unknown
>> attribute. In order to suppress the warnings, w
Jonathan Nieder writes:
> Junio C Hamano wrote:
>
>> It seems to apply well on the tip of jk/gcc-function-attributes.
>>
>> - This macro is not about "git" at all, so I'll edit the patch to
>>call it GCC_ATTR_SENTINEL before applying.
>
> Would naming it something like LAST_ARG_MUST_BE_NULL
Junio C Hamano wrote:
> It seems to apply well on the tip of jk/gcc-function-attributes.
>
> - This macro is not about "git" at all, so I'll edit the patch to
>call it GCC_ATTR_SENTINEL before applying.
Would naming it something like LAST_ARG_MUST_BE_NULL instead make
sense? That way, if so
Ramsay Jones writes:
> The sentinel function attribute is not understood by versions of
> the gcc compiler prior to v4.0. At present, for earlier versions
> of gcc, the build issues 108 warnings related to the unknown
> attribute. In order to suppress the warnings, we conditionally
> define the G
Ramsay Jones wrote:
> This was built on the next branch
All the uses of the sentinel attribute seem to come from
eccb6149 (use "sentinel" function attribute for variadic
lists, 2013-07-09), so this should be okay to go on top of the
jk/gcc-function-attributes branch.
> --- a/git-compat-util.h
>
On Thu, Jul 18, 2013 at 09:02:12PM +0100, Ramsay Jones wrote:
> The sentinel function attribute is not understood by versions of
> the gcc compiler prior to v4.0. At present, for earlier versions
> of gcc, the build issues 108 warnings related to the unknown
> attribute. In order to suppress the w
The sentinel function attribute is not understood by versions of
the gcc compiler prior to v4.0. At present, for earlier versions
of gcc, the build issues 108 warnings related to the unknown
attribute. In order to suppress the warnings, we conditionally
define the GIT_SENTINEL macro to provide the
7 matches
Mail list logo