[PATCH] Adding list of p4 jobs to git commit message

2016-04-15 Thread Jan Durovec
--- git-p4.py | 12 1 file changed, 12 insertions(+) diff --git a/git-p4.py b/git-p4.py index 527d44b..a81795f 100755 --- a/git-p4.py +++ b/git-p4.py @@ -2320,6 +2320,15 @@ def extractFilesFromCommit(self, commit): fnum = fnum + 1 return files +def extract

Re: [PATCH] Adding list of p4 jobs to git commit message

2016-04-15 Thread Junio C Hamano
Jan Durovec writes: > --- A few issues. Please: (1) Sign-off your work. (2) Try to find those who are familiar with the area and Cc them. "git shortlog -s -n --since=18.months --no-merges git-p4.py" may help. (3) Follow the style of existing commits when giving a title to

Re: [PATCH] Adding list of p4 jobs to git commit message

2016-04-15 Thread Luke Diamand
On 15 April 2016 at 21:27, Junio C Hamano wrote: > Jan Durovec writes: > >> --- > > A few issues. Please: > > (1) Sign-off your work. > > (2) Try to find those who are familiar with the area and Cc them. > > "git shortlog -s -n --since=18.months --no-merges git-p4.py" > may help. > >

Re: [PATCH] Adding list of p4 jobs to git commit message

2016-04-16 Thread Jan Durovec
Hi, I tried to address all the issues and (among other things) I've added a new test case to t/t98 group (t9829-git-p4-jobs.sh). Unfortunately, Travis CI build now fails with "non-executable tests: t9829-git-p4-jobs.sh" (https://travis-ci.org/git/git/jobs/123555944) Can you please advise how to

Re: [PATCH] Adding list of p4 jobs to git commit message

2016-04-16 Thread Lars Schneider
Hi Jan, Please look closely at the Travis CI output: non-executable tests: t9829-git-p4-jobs.sh make[1]: *** [test-lint-executable] Error 1 You haven't set the execution bit for your new test script. Did you try to run your tests locally? If yes, then I wonder how it worked... On Linux/Mac you