Re: [PATCH] Allow hideRefs to match refs outside the namespace

On Sun, 01 Nov 2015 at 00:40:39, Lukas Fleischer wrote: > On Sat, 31 Oct 2015 at 18:31:23, Junio C Hamano wrote: > > [...] > > You earlier (re)discovered a good approach to introduce a new > > feature without breaking settings of existing users when we > > discussed a "whitelist". Since setting

Re: [PATCH] Allow hideRefs to match refs outside the namespace

Lukas Fleischer writes: > Now, this cannot be intended behavior and I do not think this is > something we want to retain when improving that feature. Yup, that makes me suspect that namespace support with hiderefs was done without giving much thought even stronger than

Re: [PATCH] Allow hideRefs to match refs outside the namespace

I wrote this email on Thursday but it seems like it did not make it through the mailing list. Resubmitting... On Wed, 28 Oct 2015 at 17:21:59, Junio C Hamano wrote: > Lukas Fleischer writes: > > > Right now, refs with a path outside the current namespace are replaced > > by

Re: [PATCH] Allow hideRefs to match refs outside the namespace

Lukas Fleischer writes: >> If somebody is using namespaces and has "refs/frotz/" in the >> hiderefs configuration, we hide refs/frotz/ no matter which >> namespace is being accessed. With this change, with the removal the >> check from show_ref(), wouldn't such a repository

Re: [PATCH] Allow hideRefs to match refs outside the namespace

On Sat, 31 Oct 2015 at 18:31:23, Junio C Hamano wrote: > [...] > You earlier (re)discovered a good approach to introduce a new > feature without breaking settings of existing users when we > discussed a "whitelist". Since setting the configuration to an > empty string did not do anything in the

[PATCH] Allow hideRefs to match refs outside the namespace

Right now, refs with a path outside the current namespace are replaced by ".have" before passing them to show_ref() which in turn checks whether the ref matches the hideRefs pattern. Move the check before the path substitution in show_ref_cb() such that the hideRefs feature can be used to hide

Re: [PATCH] Allow hideRefs to match refs outside the namespace

Lukas Fleischer writes: > Right now, refs with a path outside the current namespace are replaced > by ".have" before passing them to show_ref() which in turn checks > whether the ref matches the hideRefs pattern. Move the check before the > path substitution in show_ref_cb()