Re: [PATCH] Change strbuf_read_file() to return ssize_t

2015-07-07 Thread Jeff King
On Fri, Jul 03, 2015 at 03:59:32PM +0200, Michael Haggerty wrote: It is currently declared to return int, which could overflow for large files. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- This patch is against maint, but it also rebases against master without conflict. I

[PATCH] Change strbuf_read_file() to return ssize_t

2015-07-03 Thread Michael Haggerty
It is currently declared to return int, which could overflow for large files. Signed-off-by: Michael Haggerty mhag...@alum.mit.edu --- This patch is against maint, but it also rebases against master without conflict. I couldn't find any way to exploit this bug. Most callers only use this