Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT

2017-11-13 Thread Junio C Hamano
Charles Bailey writes: >> > But that we should take it anyway regardless of that since it'll *also* >> > work on Linux with your patch, and this logic makes some sense whereas >> > the other one clearly didn't and just worked by pure accident of some >> > toolchain

Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT

2017-11-12 Thread Charles Bailey
On Mon, Nov 13, 2017 at 12:53:15PM +0900, Junio C Hamano wrote: > > Thanks. This patch needs a sign-off, by the way. Signed-off-by: cbaile...@bloomberg.net (I can resend the full patch if required or if anyone requests futher changes. > > But that we should take it anyway regardless of that

Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT

2017-11-12 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Sun, Nov 12 2017, Charles Bailey jotted: > >> From: Charles Bailey >> >> If you have a pcre1 library which is compiled with JIT enabled then >> PCRE_STUDY_JIT_COMPILE will be defined whether or not the >>

Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT

2017-11-12 Thread Ævar Arnfjörð Bjarmason
On Sun, Nov 12 2017, Charles Bailey jotted: > From: Charles Bailey > > If you have a pcre1 library which is compiled with JIT enabled then > PCRE_STUDY_JIT_COMPILE will be defined whether or not the > NO_LIBPCRE1_JIT configuration is set. > > This means that we enable

[PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT

2017-11-12 Thread Charles Bailey
From: Charles Bailey If you have a pcre1 library which is compiled with JIT enabled then PCRE_STUDY_JIT_COMPILE will be defined whether or not the NO_LIBPCRE1_JIT configuration is set. This means that we enable JIT functionality when calling pcre_study even if