Re: [PATCH] Honor core.precomposeUnicode in more places

2019-07-26 Thread Jeff King
On Tue, Apr 23, 2019 at 10:30:56AM -0700, Elijah Newren wrote: > diff --git a/builtin/pack-refs.c b/builtin/pack-refs.c > index f3353564f9..cfbd5c36c7 100644 > --- a/builtin/pack-refs.c > +++ b/builtin/pack-refs.c > @@ -1,4 +1,5 @@ > #include "builtin.h" > +#include "config.h" > #include "parse-

Re: [PATCH] Honor core.precomposeUnicode in more places

2019-04-23 Thread Junio C Hamano
Elijah Newren writes: > ..., and passing a config-related callback function to > parse_options seems a little weird to me. A little? That's a moderate understatement. If parse_options API were the ONLY thing that gets affected by precompose_unicode, having an "if the config has not been read y

Re: [PATCH] Honor core.precomposeUnicode in more places

2019-04-23 Thread Elijah Newren
On Tue, Apr 23, 2019 at 11:29 AM Torsten Bögershausen wrote: > > On Tue, Apr 23, 2019 at 10:30:56AM -0700, Elijah Newren wrote: > > On Mac's HFS ("Hilarious FileSystem"? "Halfwitted FileSystem"?) -- > > How about "Hierarchical File System" ? Sorry, I should have removed my draft commentary befor

Re: [PATCH] Honor core.precomposeUnicode in more places

2019-04-23 Thread Torsten Bögershausen
On Tue, Apr 23, 2019 at 10:30:56AM -0700, Elijah Newren wrote: > On Mac's HFS ("Hilarious FileSystem"? "Halfwitted FileSystem"?) -- How about "Hierarchical File System" ? > where git sets core.precomposeUnicode to true automatically by git > init/clone -- when a user creates a simple unicode ref

[PATCH] Honor core.precomposeUnicode in more places

2019-04-23 Thread Elijah Newren
On Mac's HFS ("Hilarious FileSystem"? "Halfwitted FileSystem"?) -- where git sets core.precomposeUnicode to true automatically by git init/clone -- when a user creates a simple unicode refname (in NFC format) such as españa: $ git branch españa different commands would display the branch name