Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Junio C Hamano
Matt Kraai writes: >> Assuming that this change is about building with expat1, it would >> probably be better to do something like this instead, I would think. > > expat 1.95.0 through 1.95.8 used expat.h; should I still use > EXPAT_VERSION = 1 to signify that it should use xmlparse.h, use > EXPA

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Matt Kraai
On Mon, Feb 11, 2013 at 01:34:52PM -0800, Junio C Hamano wrote: > Two points and a possibly irrelevant half: > > - If a fix is platform specific (i.e. tempts to use #ifdef >PLATFORM_NAME), we would prefer to see a patch that that is >isolated to platform-specific compatibility layer, whic

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Junio C Hamano
Jeff King writes: > On Mon, Feb 11, 2013 at 12:59:55PM -0800, Matt Kraai wrote: > >> From: Matt Kraai >> >> QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h >> instead of expat.h, so include the former on QNX systems. > > So it is not just QNX, but rather older versions of e

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Junio C Hamano
Matt Kraai writes: > From: Matt Kraai > > QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h > instead of expat.h, so include the former on QNX systems. > > Signed-off-by: Matt Kraai > --- Two points and a possibly irrelevant half: - If a fix is platform specific (i.e. temp

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Matt Kraai
On Mon, Feb 11, 2013 at 04:06:21PM -0500, Jeff King wrote: > On Mon, Feb 11, 2013 at 12:59:55PM -0800, Matt Kraai wrote: > > > From: Matt Kraai > > > > QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h > > instead of expat.h, so include the former on QNX systems. > > So it is

Re: [PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Jeff King
On Mon, Feb 11, 2013 at 12:59:55PM -0800, Matt Kraai wrote: > From: Matt Kraai > > QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h > instead of expat.h, so include the former on QNX systems. So it is not just QNX, but rather older versions of expat? > diff --git a/http-pus

[PATCH] Include xmlparse.h instead of expat.h on QNX

2013-02-11 Thread Matt Kraai
From: Matt Kraai QNX 6.3.2 through 6.5.0 include Expat 1.1, which provides xmlparse.h instead of expat.h, so include the former on QNX systems. Signed-off-by: Matt Kraai --- http-push.c | 4 1 file changed, 4 insertions(+) diff --git a/http-push.c b/http-push.c index 9923441..55c575e 100