Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 12 2017, Junio C. Hamano jotted: > Junio C Hamano writes: > >> Ævar Arnfjörð Bjarmason writes: >> I actually think that the block can go even further down, perhaps close to the run of choices "what variant are we building?" we make at around we have "ifdef NO_CURL". >

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Junio C Hamano
Junio C Hamano writes: > Ævar Arnfjörð Bjarmason writes: > >>> I actually think that the block can go even further down, perhaps >>> close to the run of choices "what variant are we building?" we make >>> at around we have "ifdef NO_CURL". >>> >>> Ævar? >> >> Makes sense to me, do you want to sq

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> I actually think that the block can go even further down, perhaps >> close to the run of choices "what variant are we building?" we make >> at around we have "ifdef NO_CURL". >> >> Ævar? > > Makes sense to me, do you want to squash this + your proposed edit & >

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Jonathan Tan
On Tue, 12 Dec 2017 11:57:28 -0800 Junio C Hamano wrote: > Junio C Hamano writes: > > > Makes sense. The patch looks scary by appearing to move the > > includes far to the front of the Makefile, but it in fact is moving > > the NO_DC_SHA1_SUBMODULE block slightly down and it is a sensible > >

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Ævar Arnfjörð Bjarmason
On Tue, Dec 12, 2017 at 8:53 PM, Junio C Hamano wrote: > Ramsay Jones writes: > >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Junio, >> >> Could you please add (or squash) this on top of the 'ab/sha1dc-build' >> branch, so that I can build with NO_DC_SHA1_SUBMODULE=NoThanks in my >> config.mak.

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Junio C Hamano
Junio C Hamano writes: > Makes sense. The patch looks scary by appearing to move the > includes far to the front of the Makefile, but it in fact is moving > the NO_DC_SHA1_SUBMODULE block slightly down and it is a sensible > and safe move. A completely unrelated tangent. This was a good change

Re: [PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Junio C Hamano
Ramsay Jones writes: > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > Could you please add (or squash) this on top of the 'ab/sha1dc-build' > branch, so that I can build with NO_DC_SHA1_SUBMODULE=NoThanks in my > config.mak. Makes sense. The patch looks scary by appearing to move the incl

[PATCH] Makefile: allow NO_DC_SHA1_SUBMODULE to be set in config.mak

2017-12-12 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Junio, Could you please add (or squash) this on top of the 'ab/sha1dc-build' branch, so that I can build with NO_DC_SHA1_SUBMODULE=NoThanks in my config.mak. [If I were to get a vote, I would vote no to the submodule. ;-) ] Thanks! ATB, Ramsay Jones Makef