Re: [PATCH] Makefile: don't run rm without any files

2013-02-13 Thread Junio C Hamano
Matt Kraai kr...@ftbfs.org writes: From: Matt Kraai matt.kr...@amo.abbott.com rm -f -r fails on QNX when not passed any files to remove. I do not think it is limited to QNX. the clean target, since dep_dirs is empty. And dep_dirs being empty under some circumstance shouldn't be limited to

Re: [PATCH] Makefile: don't run rm without any files

2013-02-13 Thread Matt Kraai
On Wed, Feb 13, 2013 at 08:51:45AM -0800, Junio C Hamano wrote: Matt Kraai kr...@ftbfs.org writes: From: Matt Kraai matt.kr...@amo.abbott.com rm -f -r fails on QNX when not passed any files to remove. I do not think it is limited to QNX. the clean target, since dep_dirs is empty.

Re: [PATCH] Makefile: don't run rm without any files

2013-02-13 Thread Junio C Hamano
Matt Kraai kr...@ftbfs.org writes: I don't set COMPUTE_HEADER_DEPENDENCIES, so it defaults to auto. The automatic detection determines that the compiler doesn't support it, so it's then set to no. CHECK_HEADER_DEPENDENCIES isn't set either, so about 20 lines below the dep_dirs assignment you

Re: [PATCH] Makefile: don't run rm without any files

2013-02-13 Thread Jonathan Nieder
Junio C Hamano wrote: I amended the log message like so: commit bd9df384b16077337fffe9836c9255976b0e7b91 Author: Matt Kraai matt.kr...@amo.abbott.com Date: Wed Feb 13 07:57:48 2013 -0800 Makefile: don't run rm without any files When COMPUTE_HEADER_DEPENDENCIES is set to auto