Re: [PATCH] Makefile: use CXXFLAGS for linking fuzzers

2018-11-13 Thread Junio C Hamano
Josh Steadmon writes: > OSS-Fuzz only provides one set of CXXFLAGS for use on both compiling > project C++ project files as well linking the fuzzers themselves. So in > the event that Git ever added any C++ sources, they would need to use > the same set of CXXFLAGS. OK. > Given that, do you

Re: [PATCH] Makefile: use CXXFLAGS for linking fuzzers

2018-11-13 Thread Josh Steadmon
On 2018.11.13 12:12, Junio C Hamano wrote: > stead...@google.com writes: > > > OSS-Fuzz requires C++-specific flags to link fuzzers. Passing these in > > CFLAGS causes lots of build warnings. Using separate CXXFLAGS avoids > > this. > > We are not a C++ shop, so allow me to show ignorance about

Re: [PATCH] Makefile: use CXXFLAGS for linking fuzzers

2018-11-12 Thread Junio C Hamano
stead...@google.com writes: > OSS-Fuzz requires C++-specific flags to link fuzzers. Passing these in > CFLAGS causes lots of build warnings. Using separate CXXFLAGS avoids > this. We are not a C++ shop, so allow me to show ignorance about how projects that are OSS-Fuzz-enabled work. Do they use

Re: [PATCH] Makefile: use CXXFLAGS for linking fuzzers

2018-11-12 Thread Stefan Beller
On Mon, Nov 12, 2018 at 2:03 PM wrote: > > OSS-Fuzz requires C++-specific flags to link fuzzers. Passing these in > CFLAGS causes lots of build warnings. Using separate CXXFLAGS avoids > this. > That makes sense in this context, > CFLAGS = -g -O2 -Wall > +CXXFLAGS ?= $(CFLAGS) ... but

[PATCH] Makefile: use CXXFLAGS for linking fuzzers

2018-11-12 Thread steadmon
OSS-Fuzz requires C++-specific flags to link fuzzers. Passing these in CFLAGS causes lots of build warnings. Using separate CXXFLAGS avoids this. Signed-off-by: Josh Steadmon --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index