Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Sixt
Am 27.08.2015 um 23:50 schrieb Jonathan Nieder: Johannes Schindelin wrote: From: jfmc jfm...@gmail.com This means the name shown by git shortlog would be jfmc instead of Jose F. Morales. Intended? The code to open and test the second end of the pipe clearly imitates the code for the first

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi Jose, Please do not top-post; I use top-posting as a tell-tale for mails I can safely delete unread when I have too many mails in my inbox. On 2015-08-28 08:37, Jose F. Morales wrote: Ops... my fault. I was playing with the web editor and forgot that my profile didn't had my real name (now

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi, On 2015-08-28 11:39, Johannes Schindelin wrote: On 2015-08-28 08:37, Jose F. Morales wrote: Could I still amend the commit? (it seems to be already pushed into master) It was pushed to Git for Windows' master, but here it was submitted to the Git mailing list. Junio, would you

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-28 Thread Johannes Schindelin
Hi Jonathan, On 2015-08-27 23:50, Jonathan Nieder wrote: Johannes Schindelin wrote: From: jfmc jfm...@gmail.com This means the name shown by git shortlog would be jfmc instead of Jose F. Morales. Intended? Fixed in v2 ;-) Ciao, Dscho -- To unsubscribe from this list: send the line

[PATCH] Mingw: verify both ends of the pipe () call

2015-08-27 Thread Johannes Schindelin
From: jfmc jfm...@gmail.com The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix the obvious copy-edit bug. Signed-off-by: Jose F. Morales jfm...@gmail.com Signed-off-by: Johannes Schindelin

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-27 Thread Johannes Schindelin
Hi all, On 2015-08-27 17:55, Johannes Schindelin wrote: From: jfmc jfm...@gmail.com The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix the obvious copy-edit bug. Signed-off-by: Jose F. Morales

Re: [PATCH] Mingw: verify both ends of the pipe () call

2015-08-27 Thread Jonathan Nieder
Johannes Schindelin wrote: From: jfmc jfm...@gmail.com This means the name shown by git shortlog would be jfmc instead of Jose F. Morales. Intended? The code to open and test the second end of the pipe clearly imitates the code for the first end. A little too closely, though... Let's fix