Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-24 Thread Eric S. Raymond
Pete Wyckoff p...@padd.com: e...@thyrsus.com wrote on Thu, 20 Dec 2012 09:13 -0500: diff --git a/git-p4.py b/git-p4.py index 551aec9..ec060b4 100755 --- a/git-p4.py +++ b/git-p4.py @@ -12,6 +12,11 @@ import optparse, sys, os, marshal, subprocess, shelve import tempfile, getopt,

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-24 Thread Junio C Hamano
Eric S. Raymond e...@thyrsus.com writes: Pete Wyckoff p...@padd.com: e...@thyrsus.com wrote on Thu, 20 Dec 2012 09:13 -0500: ... Many of your changes have these three problems; I just picked on my favorite one. Should I resubmit, or do you intend to fix these while merging? I'd

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-24 Thread Eric S. Raymond
Junio C Hamano gits...@pobox.com: Should I resubmit, or do you intend to fix these while merging? I'd appreciate a re-roll, perhaps in a few days after the dust settles. You'll get it. It will take a little longer than it otherwise might have because I'm in the middle of straightening out

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-23 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I needed something like this on top of it to get it pass t5800. diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py index 776e891..5047fd4 100644 --- a/git_remote_helpers/git/__init__.py +++

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-23 Thread Eric S. Raymond
Junio C Hamano gits...@pobox.com: Junio C Hamano gits...@pobox.com writes: I needed something like this on top of it to get it pass t5800. diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py index 776e891..5047fd4 100644 ---

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-21 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 20/12/2012 15:13, Eric S. Raymond ha scritto: Signed-off-by: Eric S. Raymond e...@thyrsus.com --- Just my two cents. Isn't it better to have some core Python support inside a python/ directory in the git source tree (e.g. e simple

[PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-20 Thread Eric S. Raymond
Signed-off-by: Eric S. Raymond e...@thyrsus.com --- contrib/ciabot/ciabot.py | 5 + contrib/fast-import/import-zips.py | 5 + contrib/hg-to-git/hg-to-git.py | 5 + contrib/p4import/git-p4import.py | 5 + contrib/svn-fe/svnrdump_sim.py | 4 git-p4.py

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-20 Thread Jeff King
On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote: diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py index bd24395..b55648f 100755 --- a/contrib/ciabot/ciabot.py +++ b/contrib/ciabot/ciabot.py @@ -50,6 +50,11 @@ import os, sys, commands, socket, urllib from

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-20 Thread Eric S. Raymond
Jeff King p...@peff.net: On Thu, Dec 20, 2012 at 09:13:37AM -0500, Eric S. Raymond wrote: diff --git a/contrib/ciabot/ciabot.py b/contrib/ciabot/ciabot.py index bd24395..b55648f 100755 --- a/contrib/ciabot/ciabot.py +++ b/contrib/ciabot/ciabot.py @@ -50,6 +50,11 @@ import os, sys,

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-20 Thread Junio C Hamano
Eric S. Raymond e...@thyrsus.com writes: Should the error message say ciabot.py? -Peff Gack. Yes. Thaty's what I get for cut-and-pasting too quickly. The information about xnml.sex is correct, though. Want me to resubmit, or will you just patch it? Can handle it myself; thanks for the

Re: [PATCH] Python scripts audited for minimum compatible version and checks added.

2012-12-20 Thread Junio C Hamano
I needed something like this on top of it to get it pass t5800. diff --git a/git_remote_helpers/git/__init__.py b/git_remote_helpers/git/__init__.py index 776e891..5047fd4 100644 --- a/git_remote_helpers/git/__init__.py +++ b/git_remote_helpers/git/__init__.py @@ -1,3 +1,5 @@ +import sys + if