Re: [PATCH] RFC Highlight keywords in remote sideband output.

2018-07-30 Thread Han-Wen Nienhuys
On Thu, Jul 26, 2018 at 8:50 PM Junio C Hamano wrote: > Hold your objection a bit. I'll come back to it soon ;-) > > It theoretically may make more sense to color on the sender side, > but that is true only if done at a higher layer that prepares a > string and calls into the sideband code

Re: [PATCH] RFC Highlight keywords in remote sideband output.

2018-07-26 Thread Junio C Hamano
Han-Wen Nienhuys writes: > Supported keywords are "error", "warning", "hint" and "success". > > TODO: > * make the coloring optional? What variable to use? > * doc for the coloring option. > * how to test? At the sideband layer, the sender only has the same level of information as the

Re: [PATCH] RFC Highlight keywords in remote sideband output.

2018-07-26 Thread Stefan Beller
On Thu, Jul 26, 2018 at 10:18 AM Han-Wen Nienhuys wrote: > > Supported keywords are "error", "warning", "hint" and "success". Thanks for taking this upstream. :-) > > TODO: > * make the coloring optional? What variable to use? This is the natural extension of the topic merged at a56fb3dcc09

[PATCH] RFC Highlight keywords in remote sideband output.

2018-07-26 Thread Han-Wen Nienhuys
Supported keywords are "error", "warning", "hint" and "success". TODO: * make the coloring optional? What variable to use? * doc for the coloring option. * how to test? Signed-off-by: Han-Wen Nienhuys Change-Id: I090412a1288bc2caef0916447e28c2d0199da47d --- sideband.c | 69