Re: PATCH] remove duplicate #include directives

2019-10-06 Thread René Scharfe
Am 06.10.19 um 01:41 schrieb Junio C Hamano: > René Scharfe writes: >> This one here requires one more piece of information, though, namely our >> convention of wrapping header files in guard defines to make repeated >> includes of them no-ops. We do that for those removed by the patch, but >> we

Re: PATCH] remove duplicate #include directives

2019-10-05 Thread Junio C Hamano
René Scharfe writes: > It works best for changes whose effects are constrained to within the > affected functions, but have crucial information located outside the > three default lines of context. An example would be a change at the end > of a function for which a reviewer might need to know th

Re: PATCH] remove duplicate #include directives

2019-10-05 Thread René Scharfe
Am 04.10.19 um 01:15 schrieb Junio C Hamano: > René Scharfe writes: > >> Found with "git grep '^#include ' '*.c' | sort | uniq -d". >> >> Signed-off-by: René Scharfe >> --- >> Patch formatted with --function-context for easier review. > > I have a mixed feelings about that. > > The only audience

Re: PATCH] remove duplicate #include directives

2019-10-03 Thread Junio C Hamano
René Scharfe writes: > Found with "git grep '^#include ' '*.c' | sort | uniq -d". > > Signed-off-by: René Scharfe > --- > Patch formatted with --function-context for easier review. I have a mixed feelings about that. The only audience benefitted by --function-context patch are those who read t

PATCH] remove duplicate #include directives

2019-10-03 Thread René Scharfe
Found with "git grep '^#include ' '*.c' | sort | uniq -d". Signed-off-by: René Scharfe --- Patch formatted with --function-context for easier review. builtin/am.c | 1 - builtin/blame.c| 1 - builtin/clone.c| 1 - builtin/describe.c | 1 - builtin/rev-list.c | 1 - builtin/worktre

Re: [PATCH] Remove duplicate #include

2015-02-13 Thread Dilyan Palauzov
Hello Junio, in theory it speeds up, because the preprocessor has less work to do. In practice I don't know how much and this seems also irrelevant criterion for accepting this patch. Greetings Dilyan On 13.02.2015 22:15, Junio C Hamano wrote: > Дилян Палаузов writes: > >> deheader (git://g

Re: [PATCH] Remove duplicate #include

2015-02-13 Thread Junio C Hamano
Дилян Палаузов writes: > deheader (git://gitorious.org/deheader/deheader.git) found out that > some .c files #include twice one and the same header file. > > This patch removes such occurrences and hence speeds up the compilation. Does it speed up? By how much? Any numbers? I do not see any

[PATCH] Remove duplicate #include

2015-02-13 Thread Дилян Палаузов
deheader (git://gitorious.org/deheader/deheader.git) found out that some .c files #include twice one and the same header file. This patch removes such occurrences and hence speeds up the compilation. Signed-off-by: Дилян Палаузов --- builtin/fetch.c| 1 - trailer.c | 1 - transport