Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread John Keeping
On Sat, Mar 02, 2013 at 08:16:13PM +0100, Thomas Rast wrote: John Keeping j...@keeping.me.uk writes: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: On Sat, Mar 02, 2013 at 08:16:13PM +0100, Thomas Rast wrote: John Keeping j...@keeping.me.uk writes: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread John Keeping
On Sun, Mar 03, 2013 at 01:08:50PM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: On Sat, Mar 02, 2013 at 08:16:13PM +0100, Thomas Rast wrote: John Keeping j...@keeping.me.uk writes: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: On Sun, Mar 03, 2013 at 01:08:50PM -0800, Junio C Hamano wrote: Additionally, it seems that Johan added graph_set_column_colors specifically so that CGit should use it - there's no value to having that as a method just for its use in graph.c and

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread John Keeping
On Sun, Mar 03, 2013 at 02:49:12PM -0800, Junio C Hamano wrote: John Keeping j...@keeping.me.uk writes: On Sun, Mar 03, 2013 at 01:08:50PM -0800, Junio C Hamano wrote: Additionally, it seems that Johan added graph_set_column_colors specifically so that CGit should use it - there's no

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-03 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: Also it probably is worth adding contact information for folks who work on CGit (http://hjemli.net/git/cgit/ might be sufficient), The current CGit homepage is http://git.zx2c4.com/cgit/ As the hjemli.net address is what I got as the first hit by

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-02 Thread Johan Herland
On Sat, Mar 2, 2013 at 1:46 PM, John Keeping j...@keeping.me.uk wrote: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit cannot be updated to use Git 1.8.0 or

Re: [PATCH] Revert graph.c: mark private file-scope symbols as static

2013-03-02 Thread Thomas Rast
John Keeping j...@keeping.me.uk writes: This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. CGit uses these symbols to output the correct HTML around graph elements. Making these symbols private means that CGit cannot be updated to use Git 1.8.0 or newer, so let's not do that.