[PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-27 Thread Sun He
Signed-off-by: Sun He --- bulk-checkin.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/bulk-checkin.c b/bulk-checkin.c index 118c625..8c47d71 100644 --- a/bulk-checkin.c +++ b/bulk-checkin.c @@ -23,7 +23,8 @@ static struct bulk_checkin_state { static void fin

[PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread Sun He
Signed-off-by: Sun He --- builtin/pack-objects.c | 17 +++-- bulk-checkin.c | 8 +--- pack-write.c | 20 pack.h | 2 +- 4 files changed, 25 insertions(+), 22 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-o

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-27 Thread Junio C Hamano
Sun He writes: > Signed-off-by: Sun He > --- > bulk-checkin.c | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) > > diff --git a/bulk-checkin.c b/bulk-checkin.c > index 118c625..8c47d71 100644 > --- a/bulk-checkin.c > +++ b/bulk-checkin.c > @@ -23,7 +23,8 @@ static struct bu

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread Eric Sunshine
On Fri, Feb 28, 2014 at 3:28 AM, Sun He wrote: > Signed-off-by: Sun He > --- Nicely done. Due to the necessary changes to finish_tmp_packfile(), the focus of this patch has changed slightly from that suggested by the microproject. It's really now about finish_tmp_packfile() rather than finish_b

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread Eric Sunshine
On Fri, Feb 28, 2014 at 4:46 AM, Eric Sunshine wrote: > On Fri, Feb 28, 2014 at 3:28 AM, Sun He wrote: >> Signed-off-by: Sun He >> --- > > Nicely done. > > Due to the necessary changes to finish_tmp_packfile(), the focus of > this patch has changed slightly from that suggested by the > microproj

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread 孙赫
2014-02-28 21:12 GMT+08:00 Eric Sunshine [via git] : > On Fri, Feb 28, 2014 at 4:46 AM, Eric Sunshine <[hidden email]> wrote: > >> On Fri, Feb 28, 2014 at 3:28 AM, Sun He <[hidden email]> wrote: >>> Signed-off-by: Sun He <[hidden email]> >>> --- >> >> Nicely done. >> >> Due to the necessary changes

Fwd: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread 孙赫
-- Forwarded message -- From: 孙赫 Date: 2014-02-28 21:37 GMT+08:00 Subject: Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname To: "Eric Sunshine [via git]" 2014-02-28 17:47 GMT+08:00 Eric Sunshine [via git] : > On Fri, Fe

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread Eric Sunshine
On Fri, Feb 28, 2014 at 9:17 AM, 孙赫 wrote: > 2014-02-28 21:12 GMT+08:00 Eric Sunshine [via git] > : >> On Fri, Feb 28, 2014 at 4:46 AM, Eric Sunshine <[hidden email]> wrote: >> >>> On Fri, Feb 28, 2014 at 3:28 AM, Sun He <[hidden email]> wrote: Signed-off-by: Sun He <[hidden email]> ---

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread Eric Sunshine
On Fri, Feb 28, 2014 at 10:54 AM, 孙赫 wrote: > 2014-02-28 17:47 GMT+08:00 Eric Sunshine [via git] > : >> On Fri, Feb 28, 2014 at 3:28 AM, Sun He <[hidden email]> wrote: >>> Signed-off-by: Sun He <[hidden email]> >>> --- >> > diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c >> >>> index

Re: [PATCH] Rewrite bulk-checkin.c:finish_bulk_checkin() to use a strbuf for handling packname

2014-02-28 Thread He Sun
2014-03-01 4:42 GMT+08:00 Eric Sunshine : > On Fri, Feb 28, 2014 at 9:17 AM, 孙赫 wrote: >> 2014-02-28 21:12 GMT+08:00 Eric Sunshine [via git] >> : >>> On Fri, Feb 28, 2014 at 4:46 AM, Eric Sunshine <[hidden email]> wrote: >>> On Fri, Feb 28, 2014 at 3:28 AM, Sun He <[hidden email]> wrote: