Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

On 26 Apr 2016, at 01:10, SZEDER Gábor wrote: > > Quoting Junio C Hamano : > >> SZEDER Gábor writes: >> >>> You can have a look at these patches at >>> >>> https://github.com/szeder/git completion-test-multiple-bash-versions >>>

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

Quoting Junio C Hamano : SZEDER Gábor writes: You can have a look at these patches at https://github.com/szeder/git completion-test-multiple-bash-versions and perhaps you could even adapt it to LFS and/or p4 somehow. Plus if we want to be

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

SZEDER Gábor writes: > You can have a look at these patches at > > https://github.com/szeder/git completion-test-multiple-bash-versions > > and perhaps you could even adapt it to LFS and/or p4 somehow. > >> Plus if we want to be consistent we would >> need to do the same for

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

> > * One option on the Travis front would be to just test one combination > > of the 1.1 build - e.g. linux + clang + 1.1, so you'll stay within the > > 5 parallel builds while also having some coverage on lfs 1.1. > TBH I still think testing an outdated Git LFS version does not justify > +10

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

> > > On Wed, Apr 20, 2016 at 12:36 PM, Lars Schneider > wrote: >> >>> On Wed, Apr 20, 2016 at 12:00 PM, Luke Diamand wrote: On 20 April 2016 at 19:28, Ben Woosley wrote: > From: Ben Woosley

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

Thanks! Some thoughts: * One option on the Travis front would be to just test one combination of the 1.1 build - e.g. linux + clang + 1.1, so you'll stay within the 5 parallel builds while also having some coverage on lfs 1.1. * It might be risky to match on contentFile when looking for the

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

> On Wed, Apr 20, 2016 at 12:00 PM, Luke Diamand wrote: >> On 20 April 2016 at 19:28, Ben Woosley wrote: >>> From: Ben Woosley >>> >>> The git lfs pointer output was changed in: >>> https://github.com/github/git-lfs/pull/1105 >>>

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

Yep it's addressing the same problem - I developed this independently after having only viewed the github repo: https://github.com/git/git/pull/231 Things I like about my patch: 1) it maintains ongoing support for git-lfs 1.1 by retaining it in the travis CI 2) it's a fairly minimal intervention

Re: [PATCH] Update git-p4 to be compatible with git-lfs 1.2

On 20 April 2016 at 19:28, Ben Woosley wrote: > From: Ben Woosley > > The git lfs pointer output was changed in: > https://github.com/github/git-lfs/pull/1105 > > This was causing Mac Travis runs to fail, as homebrew had updated to 1.2 > while Linux

[PATCH] Update git-p4 to be compatible with git-lfs 1.2

From: Ben Woosley The git lfs pointer output was changed in: https://github.com/github/git-lfs/pull/1105 This was causing Mac Travis runs to fail, as homebrew had updated to 1.2 while Linux was pinned at 1.1 via GIT_LFS_VERSION. The travis builds against 1.1 and 1.2 both