Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-11 Thread Junio C Hamano
Junio C Hamano writes: > Rick van Hattem writes: > >> The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check >> moot. The result (at least for me) is that zsh segfaults because of all the >> variables it's unsetting. >> --- > > Overlong line, lack of sign-off. > >> # Clear

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-06 Thread Jonathan Nieder
Hi, Rick van Hattem wrote: > On 4 June 2018 at 05:40, Junio C Hamano wrote: >> Overlong line, lack of sign-off. > > Apologies for the long lines, I wrote the message on Github where this > message is properly formatted, apparently the submitgit script can be > considered broken as it truncates

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-06 Thread Rick van Hattem
On 6 June 2018 at 13:41, SZEDER Gábor wrote: > >> On 4 June 2018 at 05:40, Junio C Hamano wrote: >> Rick van Hattem writes: >> >> > > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this >> > > check moot. The result (at least for me) is that zsh segfaults because >> > > of

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-06 Thread SZEDER Gábor
> On 4 June 2018 at 05:40, Junio C Hamano wrote: > Rick van Hattem writes: > > > > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check > > > moot. The result (at least for me) is that zsh segfaults because of all > > > the variables it's unsetting. > > > --- > > > >

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-04 Thread Rick van Hattem
On 4 June 2018 at 05:40, Junio C Hamano wrote: Rick van Hattem writes: > > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check > > moot. The result (at least for me) is that zsh segfaults because of all the > > variables it's unsetting. > > --- > > Overlong line, lack of

Re: [PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-03 Thread Junio C Hamano
Rick van Hattem writes: > The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check > moot. The result (at least for me) is that zsh segfaults because of all the > variables it's unsetting. > --- Overlong line, lack of sign-off. > # Clear the variables caching builtins'

[PATCH] Use ZSH_NAME instead of ZSH_VERSION because it's redefined by git-completion.zsh

2018-06-03 Thread Rick van Hattem
The `git-completion.zsh` unsets the `$ZSH_VERSION` which makes this check moot. The result (at least for me) is that zsh segfaults because of all the variables it's unsetting. --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git