Re: [PATCH] add: do not accept pathspec magic 'attr'

2018-09-20 Thread Junio C Hamano
t; Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> Since Brandon is currently unreachable, let's do this for now. > > Thanks. This certainly make it better than the status quo. And of course, there is an interesting glitch found after I almost finish day's integrat

Re: [PATCH] add: do not accept pathspec magic 'attr'

2018-09-19 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Commit b0db704652 (pathspec: allow querying for attributes - > 2017-03-13) adds new pathspec magic 'attr' but only with > match_pathspec(). "git add" has some pathspec related code that still > does not know about 'attr' and will bail out: > > $ git add

[PATCH] add: do not accept pathspec magic 'attr'

2018-09-18 Thread Nguyễn Thái Ngọc Duy
Commit b0db704652 (pathspec: allow querying for attributes - 2017-03-13) adds new pathspec magic 'attr' but only with match_pathspec(). "git add" has some pathspec related code that still does not know about 'attr' and will bail out: $ git add ':(attr:foo)' fatal: BUG:dir.c:1584: