Re: [PATCH] add core.usereplacerefs config option

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 04:31:52PM -0400, Jeff King wrote: > Since Stefan's patch logically undoes ecef23, I think that's why he > put in the comment to move back to the old name. > > Personally, I do not find one name any more informative than the other, > and would be happy to leave it

Re: [PATCH] add core.usereplacerefs config option

2018-07-18 Thread Stefan Beller
On Wed, Jul 18, 2018 at 1:31 PM Jeff King wrote: > > On Wed, Jul 18, 2018 at 04:23:20PM -0400, Derrick Stolee wrote: > > > This patch looks good to me. The only thing I saw was when I ran 'git grep > > check_replace_refs' and saw the following in environment.c: > > > > int check_replace_refs

Re: [PATCH] add core.usereplacerefs config option

2018-07-18 Thread Jeff King
On Wed, Jul 18, 2018 at 04:23:20PM -0400, Derrick Stolee wrote: > This patch looks good to me. The only thing I saw was when I ran 'git grep > check_replace_refs' and saw the following in environment.c: > >     int check_replace_refs = 1; /* NEEDSWORK: rename to read_replace_refs */ > > This

Re: [PATCH] add core.usereplacerefs config option

2018-07-18 Thread Derrick Stolee
On 7/18/2018 4:17 PM, Jeff King wrote: We can already disable replace refs using a command line option or environment variable, but those are awkward to apply universally. Let's add a config option to do the same thing. That raises the question of why one might want to do so universally. The

[PATCH] add core.usereplacerefs config option

2018-07-18 Thread Jeff King
We can already disable replace refs using a command line option or environment variable, but those are awkward to apply universally. Let's add a config option to do the same thing. That raises the question of why one might want to do so universally. The answer is that replace refs violate the