[PATCH] add_submodule_odb: initialize alt_odb list earlier

2015-10-28 Thread Jeff King
On Wed, Oct 28, 2015 at 02:35:23PM +0100, Mathias L. Baumann wrote: > I was using the latest git version 2.6.2 already. > I suspect it is due to a .gitconfig. This is what is probably required: > > ➜ ~ cat .gitconfig > [diff] > submodule = log Yeah, I can reproduce it easily with that.

Re: [PATCH] add_submodule_odb: initialize alt_odb list earlier

2015-10-28 Thread Junio C Hamano
Jeff King writes: > Yeah, I can reproduce it easily with that. Thanks for providing the > repository. It takes a rather convoluted set of conditions to trigger > the bug. :) > > Here's the fix: > > -- >8 -- > Subject: add_submodule_odb: initialize alt_odb list earlier > > The

Re: [PATCH] add_submodule_odb: initialize alt_odb list earlier

2015-10-28 Thread Jeff King
On Wed, Oct 28, 2015 at 08:24:17AM -0700, Junio C Hamano wrote: > > Note that we can remove the prepare_alt_odb call from the > > end. It is guaranteed to be a noop, since we will have > > called it earlier. > > Thanks for a quick and detailed diagnosis and a fix. > > The removal is correct,