Re: [PATCH] am: support --quit

2018-02-23 Thread Junio C Hamano
Duy Nguyen writes: >> The internal implementation detail of am_abort() is leaking out >> here, by saying "rerere-clear" is the only special thing other than >> recovering the HEAD and working tree state when abort happens. It >> makes readers wonder if am_rerere_clear()

Re: [PATCH] am: support --quit

2018-02-23 Thread Duy Nguyen
On Thu, Feb 15, 2018 at 2:26 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Among the "in progress" commands, only git-am and git-merge do not >> support --quit. Support --quit in git-am too. > > That's a strange way to phrase it, when the

Re: [PATCH] am: support --quit

2018-02-14 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Among the "in progress" commands, only git-am and git-merge do not > support --quit. Support --quit in git-am too. That's a strange way to phrase it, when the number of commands that know and do not know it are about the same. > --abort:: >

[PATCH] am: support --quit

2018-02-14 Thread Nguyễn Thái Ngọc Duy
Among the "in progress" commands, only git-am and git-merge do not support --quit. Support --quit in git-am too. Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/git-am.txt | 6 +- builtin/am.c | 12 ++--