[PATCH] apply: mark some file-local symbols static

2016-08-02 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Christian, I had intended to ask you to squash this into your 'cc/apply-am' branch, specifically commit 4d18b33a (apply: move libified code from builtin/apply.c to apply.{c,h}, 30-07-2016). However, having read that commit a little closer, it seems that you d

Re: [PATCH] apply: mark some file-local symbols static

2016-08-02 Thread Junio C Hamano
On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > --- > > Hi Christian, > > I had intended to ask you to squash this into your 'cc/apply-am' > branch, specifically commit 4d18b33a (apply: move libified code > from builtin/apply.c to apply.{c,h}, 30-07-2016). >

Re: [PATCH] apply: mark some file-local symbols static

2016-08-03 Thread Christian Couder
Hi Ramsay, On Wed, Aug 3, 2016 at 12:44 AM, Junio C Hamano wrote: > On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones > wrote: >> >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Christian, >> >> I had intended to ask you to squash this into your 'cc/apply-am' >> branch, specifically commit 4d18b33a (

Re: [PATCH] apply: mark some file-local symbols static

2016-08-03 Thread Ramsay Jones
On 03/08/16 10:47, Christian Couder wrote: > Hi Ramsay, > > On Wed, Aug 3, 2016 at 12:44 AM, Junio C Hamano wrote: >> On Tue, Aug 2, 2016 at 3:33 PM, Ramsay Jones >> wrote: >>> >>> Signed-off-by: Ramsay Jones >>> --- >>> >>> Hi Christian, >>> [snip] >>> What am I missing? > > These symbols

Re: [PATCH] apply: mark some file-local symbols static

2016-08-03 Thread Johannes Schindelin
Hi Christian, On Wed, 3 Aug 2016, Christian Couder wrote: > Now there are different options to fix this: > > 1) remove the symbols in 9f87c22 ("apply: refactor `git apply` option > parsing") at the end of the series, or > 2) move 4820e13 (apply: make some parsing functions static again) at > the

Re: [PATCH] apply: mark some file-local symbols static

2016-08-07 Thread Christian Couder
Hi Dscho, On Wed, Aug 3, 2016 at 4:37 PM, Johannes Schindelin wrote: > Hi Christian, > > On Wed, 3 Aug 2016, Christian Couder wrote: > >> Now there are different options to fix this: >> >> 1) remove the symbols in 9f87c22 ("apply: refactor `git apply` option >> parsing") at the end of the series,