Re: [PATCH] archive-tar: fix a sparse 'constant too large' warning

2017-05-07 Thread Junio C Hamano
Ramsay Jones writes: > Sure, I can add this. (Although, I don't think it actually > matters). > > Hmm, unless somebody objects in the meantime, I will re-roll > the patch (tomorrow, it's late!). Thanks.

Re: [PATCH] archive-tar: fix a sparse 'constant too large' warning

2017-05-04 Thread Ramsay Jones
On 04/05/17 10:26, Johannes Schindelin wrote: > Hi Ramsay, > > On Thu, 4 May 2017, Ramsay Jones wrote: > >> diff --git a/archive-tar.c b/archive-tar.c >> index 319a5b1c7..6dddc0cff 100644 >> --- a/archive-tar.c >> +++ b/archive-tar.c >> @@ -33,7 +33,7 @@ static int write_tar_filter_archive(cons

Re: [PATCH] archive-tar: fix a sparse 'constant too large' warning

2017-05-04 Thread Johannes Schindelin
Hi Ramsay, On Thu, 4 May 2017, Ramsay Jones wrote: > diff --git a/archive-tar.c b/archive-tar.c > index 319a5b1c7..6dddc0cff 100644 > --- a/archive-tar.c > +++ b/archive-tar.c > @@ -33,7 +33,7 @@ static int write_tar_filter_archive(const struct archiver > *ar, > #if TIME_MAX == 0x > #d

[PATCH] archive-tar: fix a sparse 'constant too large' warning

2017-05-03 Thread Ramsay Jones
Commit dddbad728c ("timestamp_t: a new data type for timestamps", 26-04-2017) introduced a new typedef 'timestamp_t', as a synonym for an unsigned long, which was used at the time to represent timestamps in git. A later commit 28f4aee3fb ("use uintmax_t for timestamps", 26-04-2017) changed the typ