On Fri, May 29, 2015 at 2:40 PM, Junio C Hamano gits...@pobox.com wrote:
Quentin Neill quentin.ne...@gmail.com writes:
Thanks for the thorough review!
I have adjusted the commit messages and updated the documentation changes.
I'm in trying to add tests, I'll probably have some issues but
Quentin Neill quentin.ne...@gmail.com writes:
Thanks for the thorough review!
I have adjusted the commit messages and updated the documentation changes.
I'm in trying to add tests, I'll probably have some issues but will
post something that works soon.
Hi, I was sweeping my old mailbox for
Eric Sunshine sunsh...@sunshineco.com writes:
On Thu, Apr 30, 2015 at 10:03 AM, Quentin Neill quentin.ne...@gmail.com
wrote:
I'm thinking of a test file that will test all the git blame options,
but for this
patch it will only test the new showEmail config. I read t/README and
tentatively
Eric Sunshine sunsh...@sunshineco.com writes:
Right. Rather than having a separate global 'show_email' variable and
consulting that variable in parallel with OUTPUT_SHOW_EMAIL throughout
the code, instead set the OUTPUT_SHOW_EMAIL bit in git_blame_config().
To do this, take advantage of the
On Mon, Apr 27, 2015 at 9:46 AM, Quentin Neill quentin.ne...@gmail.com wrote:
On Fri, Apr 24, 2015 at 12:22 AM, Eric Sunshine sunsh...@sunshineco.com
wrote:
It's not clear why you relocated documentation of --show-email from
git-blame.txt to blame-options.txt, and the commit message does not
Thanks for the thorough review!
I have adjusted the commit messages and updated the documentation changes.
I'm in trying to add tests, I'll probably have some issues but will
post something that works soon.
As for the comments on behavior, see my responses below.
--
Quentin
There! His Majesty
Quentin Neill quentin.ne...@gmail.com writes:
It's not clear why you relocated documentation of --show-email from
git-blame.txt to blame-options.txt, and the commit message does not
explain the move. If there's a good reason for the relocation, the
justification should be spelled out so that
On Mon, Apr 27, 2015 at 2:10 PM, Junio C Hamano gits...@pobox.com wrote:
Quentin Neill quentin.ne...@gmail.com writes:
Eric Sunshine sunsh...@sunshineco.com writes:
Quentin Neill quentin.ne...@gmail.com writes:
- if (opt OUTPUT_SHOW_EMAIL)
+ if
Thanks for the submission. See comments below...
On Thu, Apr 23, 2015 at 10:13 PM, Quentin Neill quentin.ne...@gmail.com wrote:
From: Quentin Neill quentin.ne...@gmail.com
You should drop this line. git-am will pluck your name and email
automatically from the email From: header.
If
From: Quentin Neill quentin.ne...@gmail.com
If you prefer seeing emails in your git blame output, rather
than sprinkling '-e' options everywhere you can just set
the new config blame.showemail to true.
---
Documentation/blame-options.txt | 5 +
10 matches
Mail list logo
