[PATCH] branch.c: delete size check of newly tracked branch names

2014-02-28 Thread Jacopo Notarstefano
Since commit 6f084a56 the length of a newly tracked branch name was limited to 1019 = 1024 - 7 - 7 - 1 characters, a bound derived by having to store this name in a char[1024] called key with two strings of length at most 7 and a '\0' character. This was no longer necessary as of commit a9f2c136,

Re: [PATCH] branch.c: delete size check of newly tracked branch names

2014-02-28 Thread Jacopo Notarstefano
This patch removes this unneeded check and thus allows for branch names longer than 1019 characters. Ach! I amended the commit in my local history to read Remove this unneded check and thus allow for branch names longer than 1019 characters, but for some reason git format-patch -1 --signoff

Re: [PATCH] branch.c: delete size check of newly tracked branch names

2014-02-28 Thread Jacopo Notarstefano
Nice. new_ref is passed in install_branch_config() in latest code. I guess you already made sure this function did not make any assumption about new_ref's length? The function install_branch_config uses the strbuf, as I wrote in the commit message. The contents of this buffer are then fed to

Re: [PATCH] branch.c: delete size check of newly tracked branch names

2014-02-28 Thread Duy Nguyen
On Fri, Feb 28, 2014 at 7:14 PM, Jacopo Notarstefano jacopo.notarstef...@gmail.com wrote: Nice. new_ref is passed in install_branch_config() in latest code. I guess you already made sure this function did not make any assumption about new_ref's length? The function install_branch_config uses