Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-07 Thread Kim Gybels
On (06/07/18 12:24), Junio C Hamano wrote: > > Jeff King writes: > > > On Thu, Jul 05, 2018 at 09:50:53PM +0200, Beat Bolli wrote: > > > >> > Your patch is obviously correct, but I think here there might be an even > >> > simpler solution: just bump option_parse_type() below the declaration, >

Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-06 Thread Junio C Hamano
Jeff King writes: > On Thu, Jul 05, 2018 at 09:50:53PM +0200, Beat Bolli wrote: > >> > Your patch is obviously correct, but I think here there might be an even >> > simpler solution: just bump option_parse_type() below the declaration, >> > since it's the only one that needs it. That hunk is

Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-05 Thread Jeff King
On Thu, Jul 05, 2018 at 09:50:53PM +0200, Beat Bolli wrote: > > Your patch is obviously correct, but I think here there might be an even > > simpler solution: just bump option_parse_type() below the declaration, > > since it's the only one that needs it. That hunk is bigger, but the > > overall

Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-05 Thread Beat Bolli
Hi Peff On 05.07.18 21:38, Jeff King wrote: > On Thu, Jul 05, 2018 at 08:34:45PM +0200, Beat Bolli wrote: > >> As reported here[0], Microsoft Visual Studio 2017.2 and "gcc -pedantic" >> don't understand the forward declaration of an unsized static array. >> They insist on an array size: >> >>

Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-05 Thread Jeff King
On Thu, Jul 05, 2018 at 08:34:45PM +0200, Beat Bolli wrote: > As reported here[0], Microsoft Visual Studio 2017.2 and "gcc -pedantic" > don't understand the forward declaration of an unsized static array. > They insist on an array size: > > d:\git\src\builtin\config.c(70,46): error C2133: >

Re: [PATCH] builtin/config: work around an unsized array forward declaration

2018-07-05 Thread Taylor Blau
On Thu, Jul 05, 2018 at 08:34:45PM +0200, Beat Bolli wrote: > As reported here[0], Microsoft Visual Studio 2017.2 and "gcc -pedantic" > don't understand the forward declaration of an unsized static array. > They insist on an array size: > > d:\git\src\builtin\config.c(70,46): error C2133: >

[PATCH] builtin/config: work around an unsized array forward declaration

2018-07-05 Thread Beat Bolli
As reported here[0], Microsoft Visual Studio 2017.2 and "gcc -pedantic" don't understand the forward declaration of an unsized static array. They insist on an array size: d:\git\src\builtin\config.c(70,46): error C2133: 'builtin_config_options': unknown size The thread [1] explains that