Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-10 Thread Stefan Beller
On Tue, Oct 9, 2018 at 5:10 PM Jonathan Tan wrote: > > > It claimed that grep would still need some explicit handling, but that is > > not the call to repo_read_gitmodules (applying this patch on top of > > ff6f1f564c4 still keep the test suite happy, specifically > >

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-09 Thread Jonathan Tan
> It claimed that grep would still need some explicit handling, but that is > not the call to repo_read_gitmodules (applying this patch on top of > ff6f1f564c4 still keep the test suite happy, specifically > t7814-grep-recurse-submodules, which contains a test > "grep history with moved

[PATCH] builtin/grep.c: remote superflous submodule code

2018-10-09 Thread Stefan Beller
In f9ee2fcdfa (grep: recurse in-process using 'struct repository', 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep to simplify the submodule handling. After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules file, 2017-08-03) this is no longer necessary,

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-08 Thread Stefan Beller
> Well, submodule-config.c has its implementation and another caller, > which technically is outside submodule.c ;-) i.e. there is a typo in my commit message. I meant to say submodule-config.c > repo_read_gitmodules > has two more callers in unpack-trees.c these days, so perhaps we can > do

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: > After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules > file, 2017-08-03) this is no longer necessary, but that commit did not > cleanup the whole tree, but just show cased the new way how to deal with > submodules in ls-files. The log message of the

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Junio C Hamano
Stefan Beller writes: > In f9ee2fcdfa (grep: recurse in-process using 'struct repository', > 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep > to simplify the submodule handling. > > After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules > file,

Re: [PATCH] builtin/grep.c: remote superflous submodule code

2018-10-06 Thread Antonio Ospite
On Fri, 5 Oct 2018 15:45:57 -0700 Stefan Beller wrote: > In f9ee2fcdfa (grep: recurse in-process using 'struct repository', > 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep > to simplify the submodule handling. > > After ff6f1f564c4 (submodule-config: lazy-load a

[PATCH] builtin/grep.c: remote superflous submodule code

2018-10-05 Thread Stefan Beller
In f9ee2fcdfa (grep: recurse in-process using 'struct repository', 2017-08-02), we introduced a call to repo_read_gitmodules in builtin/grep to simplify the submodule handling. After ff6f1f564c4 (submodule-config: lazy-load a repository's .gitmodules file, 2017-08-03) this is no longer necessary,