Christian Couder wrote:
Commit 8cc5b290 (git merge -Xoption, 25 Nov 2009) introduced
suffixcmp() with nearly the same implementation as postfixcmp()
that already existed since commit 211c8968 (Make git-remote a
builtin, 29 Feb 2008).
[...]
Signed-off-by: Christian Couder
Christian Couder chrisc...@tuxfamily.org writes:
Commit 8cc5b290 (git merge -Xoption, 25 Nov 2009) introduced
suffixcmp() with nearly the same implementation as postfixcmp()
that already existed since commit 211c8968 (Make git-remote a
builtin, 29 Feb 2008).
This nearly the same piqued my
From: Junio C Hamano gits...@pobox.com
Subject: Re: [PATCH] builtin/remote: remove postfixcmp() and use suffixcmp()
instead
Date: Mon, 04 Nov 2013 11:19:43 -0800
Christian Couder chrisc...@tuxfamily.org writes:
Commit 8cc5b290 (git merge -Xoption, 25 Nov 2009) introduced
suffixcmp
Junio C Hamano gits...@pobox.com writes:
I do not think anybody sane uses prefixcmp() or suffixcmp() for
anything but checking with zero; in other words, I suspect that all
uses of Xcmp() can be replaced with !!Xcmp(), so as a separate
clean-up patch, we may at least want to make it clear
Hi Junio,
On Mon, 4 Nov 2013, Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
I do not think anybody sane uses prefixcmp() or suffixcmp() for
anything but checking with zero; in other words, I suspect that all
uses of Xcmp() can be replaced with !!Xcmp(), so as a separate
Commit 8cc5b290 (git merge -Xoption, 25 Nov 2009) introduced
suffixcmp() with nearly the same implementation as postfixcmp()
that already existed since commit 211c8968 (Make git-remote a
builtin, 29 Feb 2008).
As postfixcmp() has always been static in builtin/remote.c
and is used nowhere else, it
6 matches
Mail list logo