Re: [PATCH] builtin/send-pack: report gpg config errors

2018-06-12 Thread Stefan Beller
On Tue, Jun 12, 2018 at 11:08 AM Jonathan Nieder wrote: > > Hi, > > Stefan Beller wrote: > > > Any caller except of git_gpg_config() except the one in send_pack_config() > > handles the return value of git_gpg_config(). Also handle the return value > > there. > > > > Signed-off-by: Stefan Beller

Re: [PATCH] builtin/send-pack: report gpg config errors

2018-06-12 Thread Jonathan Nieder
Hi, Stefan Beller wrote: > Any caller except of git_gpg_config() except the one in send_pack_config() > handles the return value of git_gpg_config(). Also handle the return value > there. > > Signed-off-by: Stefan Beller > --- > builtin/send-pack.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH] builtin/send-pack: report gpg config errors

2018-06-12 Thread Eric Sunshine
On Tue, Jun 12, 2018 at 1:53 PM, Stefan Beller wrote: > Any caller except of git_gpg_config() except the one in send_pack_config() Drop the first "except"? Also: s/Any caller/All callers/ > handles the return value of git_gpg_config(). Also handle the return value > there. > > Signed-off-by:

[PATCH] builtin/send-pack: report gpg config errors

2018-06-12 Thread Stefan Beller
Any caller except of git_gpg_config() except the one in send_pack_config() handles the return value of git_gpg_config(). Also handle the return value there. Signed-off-by: Stefan Beller --- > Makes sense. I wonder if this was deliberate There was no need for other configuration to be loaded