Re: [PATCH] checkout: swap the order of ambiguity check for :/ syntax

2016-08-26 Thread Duy Nguyen
On Fri, Aug 26, 2016 at 12:19 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Wed, Aug 24, 2016 at 11:35 PM, Junio C Hamano wrote: >>> Nguyễn Thái Ngọc Duy writes: >>> It's not wonderful, but it's in line

Re: [PATCH] checkout: swap the order of ambiguity check for :/ syntax

2016-08-25 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Aug 24, 2016 at 11:35 PM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> It's not wonderful, but it's in line with how git-checkout stops caring >>> about ambiguity after the first argument can

Re: [PATCH] checkout: swap the order of ambiguity check for :/ syntax

2016-08-25 Thread Duy Nguyen
On Wed, Aug 24, 2016 at 11:35 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> It's not wonderful, but it's in line with how git-checkout stops caring >> about ambiguity after the first argument can be resolved as a ref >> (there's even a test

Re: [PATCH] checkout: swap the order of ambiguity check for :/ syntax

2016-08-24 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > It's not wonderful, but it's in line with how git-checkout stops caring > about ambiguity after the first argument can be resolved as a ref > (there's even a test for it, t2010.6). But that is justifiable because checkout can only ever take one

[PATCH] checkout: swap the order of ambiguity check for :/ syntax

2016-08-22 Thread Nguyễn Thái Ngọc Duy
This should speed up "git checkout :/long/path/taken/from/diffstat" because we don't have to walk through the commit graph to see if "long/path/taken/from/diffstat" exists in any commit message. This is in the the same spirit as 4db86e8 (Update :/abc ambiguity check - 2013-01-21), but instead of