Re: [PATCH] clang-format: adjust line break penalties

2017-09-30 Thread Junio C Hamano
Jonathan Nieder writes: > Hi Dscho, > > Johannes Schindelin wrote: > >> Signed-off-by: Johannes Schindelin >> --- >> .clang-format | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Well executed and well explained. Thank

Re: [PATCH] clang-format: adjust line break penalties

2017-09-29 Thread Jonathan Nieder
Stephan Beyer wrote: > On 09/29/2017 08:40 PM, Jonathan Nieder wrote: >> Going forward, is there an easy way to preview the effect of this kind >> of change (e.g., to run "make style" on the entire codebase so as to be >> able to compare the result with two different versions of >>

Re: [PATCH] clang-format: adjust line break penalties

2017-09-29 Thread Stephan Beyer
Hi, On 09/29/2017 08:40 PM, Jonathan Nieder wrote: > Going forward, is there an easy way to preview the effect of this kind > of change (e.g., to run "make style" on the entire codebase so as to be > able to compare the result with two different versions of > .clang-format)? I just ran

Re: [PATCH] clang-format: adjust line break penalties

2017-09-29 Thread Brandon Williams
On 09/29, Jonathan Nieder wrote: > Hi Dscho, > > Johannes Schindelin wrote: > > > Signed-off-by: Johannes Schindelin > > --- > > .clang-format | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > Well executed and well explained. Thank you. >

Re: [PATCH] clang-format: adjust line break penalties

2017-09-29 Thread Jonathan Nieder
Hi Dscho, Johannes Schindelin wrote: > Signed-off-by: Johannes Schindelin > --- > .clang-format | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Well executed and well explained. Thank you. Reviewed-by: Jonathan Nieder

[PATCH] clang-format: adjust line break penalties

2017-09-29 Thread Johannes Schindelin
We really, really, really want to limit the columns to 80 per line: One of the few consistent style comments on the Git mailing list is that the lines should not have more than 80 columns/line (even if 79 columns/line would make more sense, given that the code is frequently viewed as diff, and