On Wed, Jun 17, 2015 at 09:35:23AM -0700, Junio C Hamano wrote:
Of course it's hard to add to the test suite, since we do not have a way
of hitting a server that does not understand shallow (I simply fudged
server_supports() to return false on the client).
We've had the shallow
Jeff King p...@peff.net writes:
On Thu, Jun 11, 2015 at 08:02:33PM +0700, Duy Nguyen wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it not cover the
matching clone cases?
I think this replacement check
On Thu, Jun 11, 2015 at 08:02:33PM +0700, Duy Nguyen wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it not cover the
matching clone cases?
I think this replacement check would do
if ((args-depth 0 ||
On Thu, Jun 11, 2015 at 2:05 AM, Jeff King p...@peff.net wrote:
On Wed, Jun 10, 2015 at 02:35:20PM -0400, Mike Edgar wrote:
When the user passes --depth to git-clone the server's capabilities are
not currently consulted. The client will send shallow requests even if
the server does not
Michael Edgar ad...@google.com writes:
On Thu, Jun 11, 2015 at 10:32 AM, Jeff King p...@peff.net wrote:
On Thu, Jun 11, 2015 at 08:02:33PM +0700, Duy Nguyen wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it
On Thu, Jun 11, 2015 at 10:32 AM, Jeff King p...@peff.net wrote:
On Thu, Jun 11, 2015 at 08:02:33PM +0700, Duy Nguyen wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it not cover the
matching clone cases?
I
On Wed, Jun 10, 2015 at 3:05 PM, Jeff King p...@peff.net wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it not cover the
matching clone cases?
-Peff
Great question. I determined that the do_fetch_pack logic
When the user passes --depth to git-clone the server's capabilities are
not currently consulted. The client will send shallow requests even if
the server does not understand them, and the resulting error may be
unhelpful to the user. This change pre-emptively checks so git-clone can
exit with a
On Wed, Jun 10, 2015 at 02:35:20PM -0400, Mike Edgar wrote:
When the user passes --depth to git-clone the server's capabilities are
not currently consulted. The client will send shallow requests even if
the server does not understand them, and the resulting error may be
unhelpful to the user.
On Wed, Jun 10, 2015 at 04:25:45PM -0400, Michael Edgar wrote:
On Wed, Jun 10, 2015 at 3:05 PM, Jeff King p...@peff.net wrote:
I see that do_fetch_pack checks server_supports(shallow). Is that
enough to cover all fetch cases? And if it is, why does it not cover the
matching clone cases?
10 matches
Mail list logo