Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-08 Thread Duy Nguyen
On Sun, Jan 06, 2013 at 02:19:48AM -0800, Jonathan Nieder wrote: Unfortunately we forgot to forbid the --bare --separate-git-dir combination. In practice, we know no one could be using --bare with --separate-git-dir because it is broken in the following way:

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-08 Thread Jens Lehmann
Am 08.01.2013 15:16, schrieb Duy Nguyen: On Sun, Jan 06, 2013 at 02:19:48AM -0800, Jonathan Nieder wrote: Unfortunately we forgot to forbid the --bare --separate-git-dir combination. In practice, we know no one could be using --bare with --separate-git-dir because it is

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-08 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Am 08.01.2013 15:16, schrieb Duy Nguyen: On Sun, Jan 06, 2013 at 02:19:48AM -0800, Jonathan Nieder wrote: Unfortunately we forgot to forbid the --bare --separate-git-dir combination. In practice, we know no one could be using --bare with

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-08 Thread Duy Nguyen
On Wed, Jan 9, 2013 at 12:45 AM, Junio C Hamano gits...@pobox.com wrote: Jens Lehmann jens.lehm...@web.de writes: Am 08.01.2013 15:16, schrieb Duy Nguyen: On Sun, Jan 06, 2013 at 02:19:48AM -0800, Jonathan Nieder wrote: Unfortunately we forgot to forbid the --bare --separate-git-dir

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-08 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: After all, Jonathan's suggestion to forbid it was because the combination does not make sense and does not have practical uses, and forbidding it would make the command easier to explain than leaving it accepted from the command line. If you choose to go

[PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-06 Thread Nguyễn Thái Ngọc Duy
--separate-git-dir was added to clone with the repository away from standard position worktree/.git. It does not make sense to use it without creating working directory. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- On Sun, Jan 6, 2013 at 4:16 PM, Jonathan Nieder jrnie...@gmail.com

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-06 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: --separate-git-dir was added to clone with the repository away from standard position worktree/.git. It does not make sense to use it without creating working directory. Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com The patch correctly implements the

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-06 Thread Junio C Hamano
Jonathan Nieder jrnie...@gmail.com writes: Nguyễn Thái Ngọc Duy wrote: --separate-git-dir was added to clone with the repository away from standard position worktree/.git. It does not make sense to use it without creating working directory. Signed-off-by: Nguyễn Thái Ngọc Duy

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-06 Thread Duy Nguyen
On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano gits...@pobox.com wrote: I don't know what would go in the explanation here blank above, though. Is it possible that some people are relying on this option combination? I do not necessarily think we must say it happens not to work already for

Re: [PATCH] clone: forbid --bare --separate-git-dir dir

2013-01-06 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano gits...@pobox.com wrote: I don't know what would go in the explanation here blank above, though. Is it possible that some people are relying on this option combination? I do not necessarily think we must