Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-06 Thread Duy Nguyen
On Sun, Jan 6, 2013 at 1:43 PM, Junio C Hamano gits...@pobox.com wrote: How is the file that points at the real git dir removed with this fix, by the way? It's part of the worktree cleanup, pointed by junk_work_tree. And because junk_work_tree is not set up for --bare, I guess we still need to

Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-06 Thread Jonathan Nieder
Duy Nguyen wrote: And because junk_work_tree is not set up for --bare, I guess we still need to fix --bare --separate-git-dir case, or forbid it because i'm not sure if that case makes sense at all. Forbidding it makes sense to

[PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Jens Lehmann
Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the git dir won't be deleted in case the clone fails like it would be without this option. This makes

Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:17, Jens Lehmann ha scritto: Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the

Re: [PATCH] clone: support atomic operation with --separate-git-dir

2013-01-05 Thread Junio C Hamano
Jens Lehmann jens.lehm...@web.de writes: Since b57fb80a7d (init, clone: support --separate-git-dir for .git file) git clone supports the --separate-git-dir option to create the git dir outside the work tree. But when that option is used, the git dir won't be deleted in case the clone fails