[PATCH] cocci: avoid self-references in object_id transformations

2016-10-15 Thread René Scharfe
The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex, sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respectively. Make sure that the Coccinelle transformations for converting legacy function calls are not appl

Re: [PATCH] cocci: avoid self-references in object_id transformations

2016-10-15 Thread brian m. carlson
On Sat, Oct 15, 2016 at 10:25:34AM +0200, René Scharfe wrote: > The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and > oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex, > sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respectively. Make sure > that the Coccin

Re: [PATCH] cocci: avoid self-references in object_id transformations

2016-10-17 Thread Junio C Hamano
"brian m. carlson" writes: > On Sat, Oct 15, 2016 at 10:25:34AM +0200, René Scharfe wrote: >> The object_id functions oid_to_hex, oid_to_hex_r, oidclr, oidcmp, and >> oidcpy are defined as wrappers of their legacy counterparts sha1_to_hex, >> sha1_to_hex_r, hashclr, hashcmp, and hashcpy, respecti

Re: [PATCH] cocci: avoid self-references in object_id transformations

2016-10-17 Thread René Scharfe
Am 17.10.2016 um 20:08 schrieb Junio C Hamano: > ... oops. Totally unrelated to this patch, but I see these in > strbuf.cocci.patch (this is at the tip of 'pu'), which are total > nonsense. Perhaps I am running a way-stale spatch? It claims to be > "spatch version 1.0.0-rc19 with Python support

Re: [PATCH] cocci: avoid self-references in object_id transformations

2016-10-17 Thread Junio C Hamano
René Scharfe writes: > I get these instead with 6513eabcbcbcfa684d4bb2d57f61c662b870b5ca on > Debian testing with its "spatch version 1.0.4 with Python support and > with PCRE support", which look legit: They do look good. So I'd stop worrying about it and see how painful to update my copy of s