Re: [PATCH] cocci: detect useless free(3) calls

2017-02-11 Thread René Scharfe
Am 11.02.2017 um 20:31 schrieb Lars Schneider: > how do you run these checks on the entire Git source? > Do you run each semantic patch file on the source like this? > > spatch --sp-file contrib/coccinelle/qsort.cocci --dir /path/to/git/git > ... > spatch --sp-file contrib/coccinelle/free.cocci

Re: [PATCH] cocci: detect useless free(3) calls

2017-02-11 Thread Lars Schneider
> On 11 Feb 2017, at 14:58, René Scharfe wrote: > > Add a semantic patch for removing checks that cause free(3) to only be > called with a NULL pointer, as that must be a programming mistake. > > Signed-off-by: Rene Scharfe > --- > No cases are found in master or

Re: [PATCH] cocci: detect useless free(3) calls

2017-02-11 Thread Junio C Hamano
René Scharfe writes: > Add a semantic patch for removing checks that cause free(3) to only be > called with a NULL pointer, as that must be a programming mistake. > > Signed-off-by: Rene Scharfe > --- > No cases are found in master or next, but 1d263b93

[PATCH] cocci: detect useless free(3) calls

2017-02-11 Thread René Scharfe
Add a semantic patch for removing checks that cause free(3) to only be called with a NULL pointer, as that must be a programming mistake. Signed-off-by: Rene Scharfe --- No cases are found in master or next, but 1d263b93 (bisect--helper: `bisect_next_check` & bisect_voc shell