On Fri, Aug 3, 2018 at 2:26 AM Jonathan Nieder wrote:
> Eric Sunshine wrote:
> > + if (fd < 0 || fd >= ARRAY_SIZE(want_auto))
> > + BUG("file descriptor out of range: %d", fd);
>
> The indentation looks wrong here.
Yep, that's weird. I can't figure out how that got indented with four
Hi,
Eric Sunshine wrote:
> want_color_fd() is designed to work only with standard input, output,
> and error file descriptors, and stores information about each descriptor
> in an array. However, it doesn't verify that the passed-in descriptor
> lives within that set, which, with a buggy caller,
On Thu, Aug 02, 2018 at 12:24:54PM -0700, Junio C Hamano wrote:
> Eric Sunshine writes:
>
> > On Thu, Aug 2, 2018 at 1:37 PM Junio C Hamano wrote:
> >> Johannes Schindelin writes:
> >> > ACK!
> >>
> >> Did you write a buggy caller that would have been caught or helped
> >> with this change? Y
Eric Sunshine writes:
> On Thu, Aug 2, 2018 at 1:37 PM Junio C Hamano wrote:
>> Johannes Schindelin writes:
>> > ACK!
>>
>> Did you write a buggy caller that would have been caught or helped
>> with this change? You did not write the callee that is made more
>> defensive with this patch, so I
On Thu, Aug 2, 2018 at 1:37 PM Junio C Hamano wrote:
> Johannes Schindelin writes:
> > ACK!
>
> Did you write a buggy caller that would have been caught or helped
> with this change? You did not write the callee that is made more
> defensive with this patch, so I am being curious as to where tha
Johannes Schindelin writes:
> Hi Eric,
>
> On Thu, 2 Aug 2018, Eric Sunshine wrote:
>
>> want_color_fd() is designed to work only with standard input, output,
>> and error file descriptors, and stores information about each descriptor
>> in an array. However, it doesn't verify that the passed-in
Hi Eric,
On Thu, 2 Aug 2018, Eric Sunshine wrote:
> want_color_fd() is designed to work only with standard input, output,
> and error file descriptors, and stores information about each descriptor
> in an array. However, it doesn't verify that the passed-in descriptor
> lives within that set, whi
want_color_fd() is designed to work only with standard input, output,
and error file descriptors, and stores information about each descriptor
in an array. However, it doesn't verify that the passed-in descriptor
lives within that set, which, with a buggy caller, could lead to
access/assignment out
8 matches
Mail list logo