Re: [PATCH] commit: add commit.signoff config option

2015-06-25 Thread Caio Marcelo de Oliveira Filho
On Thu, Jun 25, 2015 at 5:43 AM, Christian Couder wrote: > You can use a commit template. > > Or you can use the "commit-msg" hook. For example with commands like: > > grep "^Signed-off-by:" "$1" || > echo "Signed-off-by: $(git config user.name) <$(git config user.email)>" > >>"$1" > > If you hav

Re: [PATCH] commit: add commit.signoff config option

2015-06-25 Thread Caio Marcelo de Oliveira Filho
> In both tests, you should probably use 'test_config' instead of 'git > config [...] git config --unset', it takes care of it for you (also > should prevent the case where the config is not unset when your test > fails in the middle). Posted a v2 with this improvement and the bash completion. Tha

Re: [PATCH] commit: add commit.signoff config option

2015-06-25 Thread Christian Couder
On Thu, Jun 25, 2015 at 9:32 AM, Caio Marcelo de Oliveira Filho wrote: > In projects that use Signed-off-by, it's convenient to include that line > in the commit by default. The commit.signoff config option allows to add > that line in all commits automatically. You can use a commit template. Or

Re: [PATCH] commit: add commit.signoff config option

2015-06-25 Thread Remi Galan Alfonso
Caio Marcelo de Oliveira Filho writes: > +test_expect_success 'commit.signoff config option' ' > +git config commit.signoff true && > +echo "yet another content *narf*" >> foo && > +echo "zort" | git commit -F - foo && > +git cat-file commit HEAD | sed "1,/^\$/d" >

Re: [PATCH] commit: add commit.signoff config option

2015-06-25 Thread Alexander Kuleshov
On 06/25, cmarc...@gmail.com wrote: > From: Caio Marcelo de Oliveira Filho > > In projects that use Signed-off-by, it's convenient to include that line > in the commit by default. The commit.signoff config option allows to add > that line in all commits automatically. > > Document that this conf

[PATCH] commit: add commit.signoff config option

2015-06-25 Thread Caio Marcelo de Oliveira Filho
In projects that use Signed-off-by, it's convenient to include that line in the commit by default. The commit.signoff config option allows to add that line in all commits automatically. Document that this config option can be overriden by using --no-signoff. Signed-off-by: Caio Marcelo de Oliveir

[PATCH] commit: add commit.signoff config option

2015-06-25 Thread cmarcelo
From: Caio Marcelo de Oliveira Filho In projects that use Signed-off-by, it's convenient to include that line in the commit by default. The commit.signoff config option allows to add that line in all commits automatically. Document that this config option can be overriden by using --no-signoff.