Re: [PATCH] commit: fix memory leak in `reduce_heads()`

2017-09-20 Thread Jonathan Nieder
Martin Ågren wrote: > We don't free the temporary scratch space we use with > `remove_redundant()`. Free it similar to how we do it in > `get_merge_bases_many_0()`. > > Signed-off-by: Martin Ågren > --- > commit.c | 1 + > 1 file changed, 1 insertion(+) Good catch.

Re: [PATCH] commit: fix memory leak in `reduce_heads()`

2017-09-20 Thread Jeff King
On Wed, Sep 20, 2017 at 09:47:25PM +0200, Martin Ågren wrote: > We don't free the temporary scratch space we use with > `remove_redundant()`. Free it similar to how we do it in > `get_merge_bases_many_0()`. Yep, seems very straightforward, and there are no code paths where we wouldn't want this.

[PATCH] commit: fix memory leak in `reduce_heads()`

2017-09-20 Thread Martin Ågren
We don't free the temporary scratch space we use with `remove_redundant()`. Free it similar to how we do it in `get_merge_bases_many_0()`. Signed-off-by: Martin Ågren --- commit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/commit.c b/commit.c index