Re: [PATCH] commit-template: change a message to be more intuitive

2017-09-13 Thread Kaartic Sivaraam
On Wednesday 13 September 2017 04:50 PM, Jeff King wrote: I agree with both of your points. It is very clear to me as a native speaker, but I can see how it might not be for everyone. Interestingly, the change here: - const char *explanation = _("Do not touch the line above.\nEverything

Re: [PATCH] commit-template: change a message to be more intuitive

2017-09-13 Thread Kaartic Sivaraam
On Wednesday 13 September 2017 03:59 PM, Kevin Daudt wrote: Touching something can also mean to disturb or change something, which is the meaning being used here, so it is not an incorrect use of the word. I do get your point but I should have been clearer in my commit message about the fact

Re: [PATCH] commit-template: change a message to be more intuitive

2017-09-13 Thread Jeff King
On Wed, Sep 13, 2017 at 12:29:15PM +0200, Kevin Daudt wrote: > On Tue, Sep 12, 2017 at 04:25:36PM +0530, Kaartic Sivaraam wrote: > > It's not possible to 'touch' the cut-line that is shown when the > > user requests a patch in his commit template. > > > > Touching something can also mean to dist

Re: [PATCH] commit-template: change a message to be more intuitive

2017-09-13 Thread Kevin Daudt
On Tue, Sep 12, 2017 at 04:25:36PM +0530, Kaartic Sivaraam wrote: > It's not possible to 'touch' the cut-line that is shown when the > user requests a patch in his commit template. > Touching something can also mean to disturb or change something, which is the meaning being used here, so it is no

[PATCH] commit-template: change a message to be more intuitive

2017-09-12 Thread Kaartic Sivaraam
It's not possible to 'touch' the cut-line that is shown when the user requests a patch in his commit template. So, make the sentence more intuitive. Signed-off-by: Kaartic Sivaraam --- Just a small tweak. May or may not be worth the patch. wt-status.c | 2 +- 1 file changed, 1 insertion(+), 1