[PATCH] commit.c: use the generic sha1_pos function for lookup sha1

Refactor binary search in commit_graft_pos function: use generic sha1_pos function. Signed-off-by: Dmitry S. Dolzhenko dmitrys.dolzhe...@yandex.ru --- commit.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/commit.c b/commit.c index 6bf4fe0..8edaeb7

Re: [PATCH] commit.c: use the generic sha1_pos function for lookup sha1

On Wed, Feb 26, 2014 at 02:07:47PM +0400, Dmitry S. Dolzhenko wrote: Refactor binary search in commit_graft_pos function: use generic sha1_pos function. Sounds sensible. A few administrative points for your patch: - we usually try to send patches inline, rather than as attachments. It

Re: [PATCH] commit.c: use the generic sha1_pos function for lookup sha1

On Wed, Feb 26, 2014 at 5:07 PM, Dmitry S. Dolzhenko dmitrys.dolzhe...@yandex.ru wrote: Refactor binary search in commit_graft_pos function: use generic sha1_pos function. For fun, try to break your changes deliberately then run make test and see if the failed tests can lead you back to this

Re: [PATCH] commit.c: use the generic sha1_pos function for lookup sha1

Thank you for your remarks. I'll try to fix my patch and send it again. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html