[PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread Ramkumar Ramachandra
77c130 (completion: clarify ls-tree, archive, show completion, 2013-06-02) removed __git_complete_file () because it had no callers left in the file. However, to avoid breaking user scripts that may depend on this, add it back as a deprecated alias. Signed-off-by: Ramkumar Ramachandra

Re: [PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread Ramkumar Ramachandra
Felipe Contreras wrote: This is fine by me, but at some point we need to decide how we should prefix the functions that are supposed to be used by external scripts. Yeah, I thought __ meant internal :/ Also, maybe we should start adding '# TODO remove in v2.0' so we remember to do that in

Re: [PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread Felipe Contreras
On Fri, Jun 7, 2013 at 2:29 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Felipe Contreras wrote: This is fine by me, but at some point we need to decide how we should prefix the functions that are supposed to be used by external scripts. Yeah, I thought __ meant internal :/ Also,

Re: [PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: 77c130 (completion: clarify ls-tree, archive, show completion, 2013-06-02) removed __git_complete_file () because it had no callers left in the file. However, to avoid breaking user scripts that may depend on this, add it back as a deprecated

Re: [PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread SZEDER Gábor
On Fri, Jun 07, 2013 at 01:38:16PM -0700, Junio C Hamano wrote: Ramkumar Ramachandra artag...@gmail.com writes: 77c130 (completion: clarify ls-tree, archive, show completion, 2013-06-02) removed __git_complete_file () because it had no callers left in the file. However, to avoid breaking

Re: [PATCH] completion: add deprecated __git_complete_file ()

2013-06-07 Thread SZEDER Gábor
On Fri, Jun 07, 2013 at 02:25:54PM -0500, Felipe Contreras wrote: On Fri, Jun 7, 2013 at 2:09 PM, Ramkumar Ramachandra artag...@gmail.com wrote: 77c130 (completion: clarify ls-tree, archive, show completion, 2013-06-02) removed __git_complete_file () because it had no callers left in the