Re: [PATCH] completion: clear cached --options when sourcing the completion script

On Fri, Mar 23, 2018 at 6:35 PM, Junio C Hamano wrote: > Junio C Hamano writes: >> I'd say we should just add !GETTEXT_POISON prereq to the problematic >> tests. > IOW, this is the minumum required. Thanks for already committing the fix, I couldn't get

Re: [PATCH] completion: clear cached --options when sourcing the completion script

Junio C Hamano writes: > SZEDER Gábor writes: > >> Hang on, this test fails in the GETTEXT_POISON build. > > Thanks. > >> The thing is, we get the merge strategies with this piece of code in >> __git_list_merge_strategies() in master: >> >> LANG=C

Re: [PATCH] completion: clear cached --options when sourcing the completion script

SZEDER Gábor writes: > Hang on, this test fails in the GETTEXT_POISON build. Thanks. > The thing is, we get the merge strategies with this piece of code in > __git_list_merge_strategies() in master: > > LANG=C LC_ALL=C git merge -s help 2>&1 | > sed -n -e

Re: [PATCH] completion: clear cached --options when sourcing the completion script

On Thu, Mar 22, 2018 at 3:16 PM, SZEDER Gábor wrote: > Add tests to ensure that these variables are indeed cleared when the > completion script is sourced; not just the variables caching options, > but all other caching variables, i.e. the variables caching commands, >

Re: [PATCH] completion: clear cached --options when sourcing the completion script

On Thu, Mar 22, 2018 at 3:16 PM, SZEDER Gábor wrote: > The established way to update the completion script in an already > running shell is to simply source it again: this brings in any new > --options and features, and clears caching variables. E.g. it clears > the

[PATCH] completion: clear cached --options when sourcing the completion script

The established way to update the completion script in an already running shell is to simply source it again: this brings in any new --options and features, and clears caching variables. E.g. it clears the variables caching the list of (all|porcelain) git commands, so when they are later