Re: [PATCH] completion: fix __gitcomp_builtin no longer consider extra options

2018-10-22 Thread SZEDER Gábor
On Mon, Oct 22, 2018 at 04:34:16PM +0200, Duy Nguyen wrote: > On Mon, Oct 22, 2018 at 5:51 AM Junio C Hamano wrote: > > > > Nguyễn Thái Ngọc Duy writes: > > > > > __gitcomp_builtin() has the main completion list provided by > > > > > > git xxx --git-completion-helper > > > > > > but the

Re: [PATCH] completion: fix __gitcomp_builtin no longer consider extra options

2018-10-22 Thread Duy Nguyen
On Mon, Oct 22, 2018 at 5:51 AM Junio C Hamano wrote: > > Nguyễn Thái Ngọc Duy writes: > > > __gitcomp_builtin() has the main completion list provided by > > > > git xxx --git-completion-helper > > > > but the caller can also add extra options that is not provided by > >

Re: [PATCH] completion: fix __gitcomp_builtin no longer consider extra options

2018-10-21 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > __gitcomp_builtin() has the main completion list provided by > > git xxx --git-completion-helper > > but the caller can also add extra options that is not provided by > --git-completion-helper. The only call site that does this is "git > difftool" completion.

[PATCH] completion: fix __gitcomp_builtin no longer consider extra options

2018-10-21 Thread Nguyễn Thái Ngọc Duy
__gitcomp_builtin() has the main completion list provided by git xxx --git-completion-helper but the caller can also add extra options that is not provided by --git-completion-helper. The only call site that does this is "git difftool" completion. This support is broken by b221b5ab9b