Re: [PATCH] completion: optionally disable checkout DWIM

2017-06-29 Thread Jason Karns
> We could discern between more than just empty vs. non-empty state of > the environment variable, e.g.: > > - if empty/unset, then include "DWIM" suggestions. > - if set to 'config', then query the 'completion.checkoutNoGuess' >configuration variable, and omit "DWIM" suggestions if its true.

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-22 Thread SZEDER Gábor
On Fri, Apr 21, 2017 at 10:19 PM, Jeff King wrote: > On Fri, Apr 21, 2017 at 10:14:48PM +0200, SZEDER Gábor wrote: > >> >> This is flexible enough for me, but it's possible somebody would want >> >> this on a per-repo basis. I don't know that we want to read from `git >> >> config`, though, becaus

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-21 Thread Jeff King
On Fri, Apr 21, 2017 at 10:14:48PM +0200, SZEDER Gábor wrote: > >> This is flexible enough for me, but it's possible somebody would want > >> this on a per-repo basis. I don't know that we want to read from `git > >> config`, though, because it's relatively expensive to do so. People who > >> want

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-21 Thread SZEDER Gábor
On Fri, Apr 21, 2017 at 7:01 AM, Junio C Hamano wrote: > Jeff King writes: > >> When we complete branch names for "git checkout", we also >> complete remote branch names that could trigger the DWIM >> behavior. Depending on your workflow and project, this can >> be either convenient or annoying.

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-21 Thread Jacob Keller
On Thu, Apr 20, 2017 at 1:12 PM, Jeff King wrote: > When we complete branch names for "git checkout", we also > complete remote branch names that could trigger the DWIM > behavior. Depending on your workflow and project, this can > be either convenient or annoying. > > For instance, my clone of gi

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-20 Thread Junio C Hamano
Jeff King writes: > ... But I think it's really the > completion that bugs me. The DWIM is easy to avoid triggering if you > just don't feed it the remote branch names. It's the completion that > routinely leads me to doing that. :) True.

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-20 Thread Jeff King
On Thu, Apr 20, 2017 at 10:01:32PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > When we complete branch names for "git checkout", we also > > complete remote branch names that could trigger the DWIM > > behavior. Depending on your workflow and project, this can > > be either convenient

Re: [PATCH] completion: optionally disable checkout DWIM

2017-04-20 Thread Junio C Hamano
Jeff King writes: > When we complete branch names for "git checkout", we also > complete remote branch names that could trigger the DWIM > behavior. Depending on your workflow and project, this can > be either convenient or annoying. > ... > This is flexible enough for me, but it's possible someb

[PATCH] completion: optionally disable checkout DWIM

2017-04-20 Thread Jeff King
When we complete branch names for "git checkout", we also complete remote branch names that could trigger the DWIM behavior. Depending on your workflow and project, this can be either convenient or annoying. For instance, my clone of gitster.git contains 74 local "jk/*" branches, but origin contai