Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-16 Thread Junio C Hamano
Jakub Narębski writes: > On 16 April 2018 at 15:15, SZEDER Gábor wrote: >> No. 'sed' would only need need help when its input comes from a buggy >> 'set' builtin of a particular version of Bash from a particular vendor. >> >> As far as I can test this in

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-16 Thread Matthew Coleman
Disclaimer: I'm not a zsh user, so please correct anything I might have gotten wrong. I created a .zshrc with the following contents: autoload -Uz compinit compinit source /usr/local/lib/python3.6/site-packages/powerline/bindings/zsh/powerline.zsh zsh doesn't have broken Unicode output in its

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-16 Thread Jacob Keller
On Sat, Apr 14, 2018 at 6:27 AM, Jakub Narebski wrote: > SZEDER Gábor writes: >> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: >>> SZEDER Gábor writes: In Bash we can do better: run the 'compgen

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-16 Thread Jakub Narębski
On 16 April 2018 at 15:15, SZEDER Gábor wrote: > On Mon, Apr 16, 2018 at 7:10 AM, Junio C Hamano wrote: > > SZEDER Gábor writes: > >> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: > >>> SZEDER Gábor

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-16 Thread SZEDER Gábor
On Mon, Apr 16, 2018 at 7:10 AM, Junio C Hamano wrote: > SZEDER Gábor writes: > >> On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: >>> SZEDER Gábor writes: In Bash we can do better: run the 'compgen

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-15 Thread Junio C Hamano
SZEDER Gábor writes: > On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: >> SZEDER Gábor writes: >>> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_' >>> builtin command, which lists the same variables, but

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-14 Thread Jakub Narebski
SZEDER Gábor writes: > On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: >> SZEDER Gábor writes: >>> >>> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_' >>> builtin command, which lists the same variables, but

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-13 Thread SZEDER Gábor
On Fri, Apr 13, 2018 at 11:44 PM, Jakub Narebski wrote: > SZEDER Gábor writes: >> In Bash we can do better: run the 'compgen -v __gitcomp_builtin_' >> builtin command, which lists the same variables, but without a >> pipeline and 'sed' it can do so with

Re: [PATCH] completion: reduce overhead of clearing cached --options

2018-04-13 Thread Jakub Narebski
SZEDER Gábor writes: > To get the names of all '$__git_builtin_*' variables caching --options > of builtin commands in order to unset them, 8b0eaa41f2 (completion: > clear cached --options when sourcing the completion script, > 2018-03-22) runs a 'set |sed s///' pipeline.

[PATCH] completion: reduce overhead of clearing cached --options

2018-04-13 Thread SZEDER Gábor
To get the names of all '$__git_builtin_*' variables caching --options of builtin commands in order to unset them, 8b0eaa41f2 (completion: clear cached --options when sourcing the completion script, 2018-03-22) runs a 'set |sed s///' pipeline. This works both in Bash and in ZSH, but has a higher