Re: [PATCH] config: add show_err flag to git_config_parse_key()

2015-02-11 Thread Junio C Hamano
Jeff King writes: > On Wed, Feb 11, 2015 at 01:15:05AM +0530, Tanay Abhra wrote: > >> I just saw your mail late in the night (I didn't had net for a week). >> This patch just squelches the error message, I will take a better >> look tomorrow morning. > > Thanks, this is probably a good first step

Re: [PATCH] config: add show_err flag to git_config_parse_key()

2015-02-10 Thread Jeff King
On Wed, Feb 11, 2015 at 01:15:05AM +0530, Tanay Abhra wrote: > I just saw your mail late in the night (I didn't had net for a week). > This patch just squelches the error message, I will take a better > look tomorrow morning. Thanks, this is probably a good first step. We can worry about making t

[PATCH] config: add show_err flag to git_config_parse_key()

2015-02-10 Thread Tanay Abhra
`git_config_parse_key()` is used to sanitize the input key. Some callers of the function like `git_config_set_multivar_in_file()` get the per-sanitized key directly from the user so it becomes necessary to raise an error specifying what went wrong when the entered key is defective. Other callers l

Re: [PATCH] config: add show_err flag to git_config_parse_key()

2014-10-30 Thread Tanay Abhra
>> --- >> >> Hi, >> >> You were right, one of the functions was calling git_config_parse_key() >> which was leaking errors to the console. git_config_parse_key() was >> meant for sanitizing user provided keys only but it was being used >> internally in a place where only a return value would be eno

Re: [PATCH] config: add show_err flag to git_config_parse_key()

2014-10-30 Thread Junio C Hamano
Tanay Abhra writes: > `git_config_parse_key()` is used to sanitize the input key. > Some callers of the function like `git_config_set_multivar_in_file()` > get the pre-sanitized key directly from the user so it becomes > necessary to raise an error specifying what went wrong when the entered > ke

Re: [PATCH] config: add show_err flag to git_config_parse_key()

2014-10-30 Thread Tanay Abhra
>From c87ddf6397964154932d49385ed1433b62631f30 Mon Sep 17 00:00:00 2001 From: Tanay Abhra Date: Thu, 30 Oct 2014 08:54:58 -0700 Subject: [PATCH] config: add show_err flag to git_config_parse_key() `git_config_parse_key()` is used to sanitize the input key. Some callers of the function l

[PATCH] config: add show_err flag to git_config_parse_key()

2014-10-30 Thread Tanay Abhra
`git_config_parse_key()` is used to sanitize the input key. Some callers of the function like `git_config_set_multivar_in_file()` get the pre-sanitized key directly from the user so it becomes necessary to raise an error specifying what went wrong when the entered key is defective. Other callers l