Re: [PATCH] config: do not use C function names as struct members

2013-08-26 Thread Junio C Hamano
Jeff King writes: > On Mon, Aug 26, 2013 at 04:59:01PM -0400, Jeff King wrote: > >> Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their >> stdio.h, it looks like that is a possibility. >> >> I think they are probably wrong to do so (but I'd have to check the >> standard). However, t

Re: [PATCH] config: do not use C function names as struct members

2013-08-26 Thread Lukas Fleischer
On Mon, Aug 26, 2013 at 05:57:18PM -0400, Jeff King wrote: > On Mon, Aug 26, 2013 at 04:59:01PM -0400, Jeff King wrote: > > > Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their > > stdio.h, it looks like that is a possibility. > > > > I think they are probably wrong to do so (but I'

[PATCH] config: do not use C function names as struct members

2013-08-26 Thread Jeff King
On Mon, Aug 26, 2013 at 04:59:01PM -0400, Jeff King wrote: > Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their > stdio.h, it looks like that is a possibility. > > I think they are probably wrong to do so (but I'd have to check the > standard). However, the cleaner workaround would