Re: [PATCH] demonstrate git-commit --dry-run exit code behaviour

2014-02-24 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 21, 2014 at 12:21:13PM -0800, Junio C Hamano wrote: > >> Tay Ray Chuan writes: >> >> > In particular, show that --short and --porcelain, while implying >> > --dry-run, do not return the same exit code as --dry-run. This is due to >> > the wt_status.commitable fla

Re: [PATCH] demonstrate git-commit --dry-run exit code behaviour

2014-02-22 Thread Jeff King
On Fri, Feb 21, 2014 at 12:21:13PM -0800, Junio C Hamano wrote: > Tay Ray Chuan writes: > > > In particular, show that --short and --porcelain, while implying > > --dry-run, do not return the same exit code as --dry-run. This is due to > > the wt_status.commitable flag being set only when a long

Re: [PATCH] demonstrate git-commit --dry-run exit code behaviour

2014-02-21 Thread Junio C Hamano
Tay Ray Chuan writes: > In particular, show that --short and --porcelain, while implying > --dry-run, do not return the same exit code as --dry-run. This is due to > the wt_status.commitable flag being set only when a long status is > requested. I am not sure if --short/--porcelain should even b

[PATCH] demonstrate git-commit --dry-run exit code behaviour

2014-02-21 Thread Tay Ray Chuan
In particular, show that --short and --porcelain, while implying --dry-run, do not return the same exit code as --dry-run. This is due to the wt_status.commitable flag being set only when a long status is requested. No fix is provided here; with [1], it should be trivial to fix though - just a mat